Skip to content

GenAI Utils | Update ToolCall Type#4218

Merged
lzchen merged 34 commits intoopen-telemetry:mainfrom
keith-decker:pr1-enhance-toolcall-type
Mar 27, 2026
Merged

GenAI Utils | Update ToolCall Type#4218
lzchen merged 34 commits intoopen-telemetry:mainfrom
keith-decker:pr1-enhance-toolcall-type

Conversation

@keith-decker
Copy link
Copy Markdown
Contributor

@keith-decker keith-decker commented Feb 19, 2026

Description

Update the tool type to match semantic conventions for GenAI Spans.

TelemetryHandler functions for start_tool and stop_tool coming in next PR.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • basic setters and getter functions

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@keith-decker keith-decker force-pushed the pr1-enhance-toolcall-type branch from f766cd6 to 9b3f2a6 Compare February 19, 2026 22:59
@keith-decker keith-decker marked this pull request as ready for review February 23, 2026 18:30
@keith-decker
Copy link
Copy Markdown
Contributor Author

I think the docker tests failure is unrelated to this PR.

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py
Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated
@aabmass
Copy link
Copy Markdown
Member

aabmass commented Feb 26, 2026

I'm a little confused.ToolCall is just a wrapper as part of GenAI util for instrumentation purposes? This is separate from the ToolCallRequest and ToolCallResponse json schemas in here which defines an actual data format.

Is that right?

Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated
@tammy-baylis-swi tammy-baylis-swi moved this to Ready for review in Python PR digest Feb 26, 2026
@tammy-baylis-swi tammy-baylis-swi moved this from Ready for review to Reviewed PRs that need fixes in Python PR digest Feb 26, 2026
Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py
Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated
Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py Outdated
Comment thread util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py
@xrmx xrmx moved this from Reviewed PRs that need fixes to Approved PRs in Python PR digest Mar 20, 2026
Comment thread util/opentelemetry-util-genai/CHANGELOG.md Outdated
@lzchen lzchen merged commit a428585 into open-telemetry:main Mar 27, 2026
860 checks passed
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Python PR digest Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.