Try to open file in UploadCompletionHook initializer with given path to ensure file upload works#4390
Merged
aabmass merged 9 commits intoopen-telemetry:mainfrom Apr 2, 2026
Merged
Conversation
aabmass
approved these changes
Apr 2, 2026
…try-python-contrib into test_file_exists
lmolkova
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make a change to try to open a file in
UploadCompletionHookinitializer with the given path in the given format to ensure file upload works, if it fails raise an error...The current implementation doesn't check the path, lets a bad path get passed in, and then when the upload hook is invoked we repeatedly fail.. Better to check if things are working upfront and throw a more understandable error..
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests.. Tested locally by running the following code:
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.