Skip to content

Commit 7247af7

Browse files
authored
opentelemetry-sdk: change sdk metrics related parameters as named (#4937)
So that it's easier to rework code if we ever need to.
1 parent 87160d0 commit 7247af7

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

  • opentelemetry-sdk/src/opentelemetry/sdk/trace

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -817,6 +817,7 @@ def __init__(
817817
set_status_on_exception: bool = True,
818818
limits=_UnsetLimits,
819819
instrumentation_scope: Optional[InstrumentationScope] = None,
820+
*,
820821
record_end_metrics: Optional[Callable[[], None]] = None,
821822
) -> None:
822823
if resource is None:
@@ -1114,8 +1115,8 @@ def __init__(
11141115
instrumentation_info: InstrumentationInfo,
11151116
span_limits: SpanLimits,
11161117
instrumentation_scope: InstrumentationScope,
1117-
meter_provider: Optional[metrics_api.MeterProvider] = None,
11181118
*,
1119+
meter_provider: Optional[metrics_api.MeterProvider] = None,
11191120
_tracer_provider: Optional["TracerProvider"] = None,
11201121
) -> None:
11211122
self.sampler = sampler
@@ -1330,8 +1331,8 @@ def __init__(
13301331
] = None,
13311332
id_generator: Optional[IdGenerator] = None,
13321333
span_limits: Optional[SpanLimits] = None,
1333-
meter_provider: Optional[metrics_api.MeterProvider] = None,
13341334
*,
1335+
meter_provider: Optional[metrics_api.MeterProvider] = None,
13351336
_tracer_configurator: Optional[_TracerConfiguratorT] = None,
13361337
) -> None:
13371338
self._active_span_processor = (
@@ -1425,7 +1426,7 @@ def get_tracer(
14251426
schema_url,
14261427
attributes,
14271428
),
1428-
self._meter_provider,
1429+
meter_provider=self._meter_provider,
14291430
_tracer_provider=self,
14301431
)
14311432

0 commit comments

Comments
 (0)