Skip to content

opentelemetry-sdk: change sdk metrics related parameters as named#4937

Merged
xrmx merged 2 commits intoopen-telemetry:mainfrom
xrmx:cleanup-sdk-methods-signatures
Feb 27, 2026
Merged

opentelemetry-sdk: change sdk metrics related parameters as named#4937
xrmx merged 2 commits intoopen-telemetry:mainfrom
xrmx:cleanup-sdk-methods-signatures

Conversation

@xrmx
Copy link
Copy Markdown
Contributor

@xrmx xrmx commented Feb 26, 2026

Description

So that it's easier to rework code if we ever need to.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner February 26, 2026 16:20
@xrmx xrmx added Skip Changelog PRs that do not require a CHANGELOG.md entry Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary labels Feb 26, 2026
So that it's easier to rework code if we ever need to.
@xrmx xrmx force-pushed the cleanup-sdk-methods-signatures branch from 5008b3f to 5a7f4ea Compare February 26, 2026 16:25
@tammy-baylis-swi tammy-baylis-swi moved this to Approved PRs in Python PR digest Feb 26, 2026
@aabmass
Copy link
Copy Markdown
Member

aabmass commented Feb 27, 2026

Just to confirm re public symbols check, this new parameter hasn't been released still correct?

@xrmx
Copy link
Copy Markdown
Contributor Author

xrmx commented Feb 27, 2026

Just to confirm re public symbols check, this new parameter hasn't been released still correct?

Yes, this has been merged recently and not released yet

@xrmx xrmx enabled auto-merge (squash) February 27, 2026 13:39
xrmx added a commit to xrmx/opentelemetry-python that referenced this pull request Feb 27, 2026
@xrmx xrmx merged commit 1c64c14 into open-telemetry:main Feb 27, 2026
550 of 551 checks passed
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Python PR digest Feb 27, 2026
Vitexus pushed a commit to Vitexus/opentelemetry-python that referenced this pull request Apr 30, 2026
Vitexus pushed a commit to Vitexus/opentelemetry-python that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants