Refactor is_valid to be an instance attribute#1005
Merged
lzchen merged 4 commits intoopen-telemetry:masterfrom Aug 27, 2020
Merged
Refactor is_valid to be an instance attribute#1005lzchen merged 4 commits intoopen-telemetry:masterfrom
lzchen merged 4 commits intoopen-telemetry:masterfrom
Conversation
Contributor
Author
|
The build passed on my end, so it probably just needs a rerun. |
Contributor
lzchen
approved these changes
Aug 27, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring of
SpanContext.is_valid()to be a variable, rather than a method. This makes the API consistent withis_remote, which is defined similarly in the specification.Since I am new to this project, I am not sure whether the removal of the method might break something downstream, but adding a deprecation warning would require also choosing a different name for the attribute.
Fixes #996
Type of change
Please delete options that are not relevant.
Checklist: