Align sampling specs in SDK#1034
Merged
lzchen merged 24 commits intoopen-telemetry:masterfrom Aug 31, 2020
Merged
Conversation
ffe4
reviewed
Aug 24, 2020
codeboten
suggested changes
Aug 27, 2020
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Most of the changes here look good, couple of minor suggestions/questions.
Should ParentOrElse be ParentBased? Looking at the spec, it looks like it was renamed: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#parentbased
aabmass
reviewed
Aug 28, 2020
Member
Also looks like |
codeboten
approved these changes
Aug 31, 2020
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Change looks good, thanks for the update!
aabmass
approved these changes
Aug 31, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #906 to adhere to https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling
Updates classes to adhere to the sampling spec.
Fixes # (issue)
Sampling changes
TODO