Rename HTTPTextFormat to TextMapPropagator#1085
Merged
lzchen merged 4 commits intoopen-telemetry:masterfrom Sep 9, 2020
Merged
Rename HTTPTextFormat to TextMapPropagator#1085lzchen merged 4 commits intoopen-telemetry:masterfrom
lzchen merged 4 commits intoopen-telemetry:masterfrom
Conversation
As per spec, this change renames the HTTPTextFormat to TextFormatPropagator. Updated the file names accordingly.
lzchen
requested changes
Sep 9, 2020
Contributor
lzchen
left a comment
lzchen
left a comment
There was a problem hiding this comment.
CHANGELOG for the api package? I believe methods like propagators.get_global_httptextformat are user facing.
Contributor
Author
Thanks for the reminder @lzchen! |
3 tasks
lzchen
approved these changes
Sep 9, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per spec, this change renames the HTTPTextFormat to TextFormatPropagator. Updated the file names accordingly.
Fixes #1083
Type of change
How Has This Been Tested?
Checklist: