Fix api/sdk setup.cfg to include missing python files#1091
Merged
lzchen merged 1 commit intoopen-telemetry:masterfrom Sep 11, 2020
Merged
Fix api/sdk setup.cfg to include missing python files#1091lzchen merged 1 commit intoopen-telemetry:masterfrom
lzchen merged 1 commit intoopen-telemetry:masterfrom
Conversation
4f6110c to
48b33d5
Compare
48b33d5 to
f844ed0
Compare
ocelotl
approved these changes
Sep 10, 2020
lzchen
approved these changes
Sep 11, 2020
2 tasks
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…n-telemetry#1091) Co-authored-by: Mayur Kale <mayurkale@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
includeline insetup.cfgwas causing only packages underopentelemetry.sdkandopentelemetryto be included, missing theopentelemetry.sdkpackage itself (withversion.pyand__init__.pyfiles). I don't think we need theincludeat all, so removed. It is not in any of the other packages' setup files.Fixes #1078
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Installing the packages (regular install, not editable) before and after into separate venvs and comparing the site-packages
Before:
After:
Diff of two venvs with
diff --color <(find venv-before/lib/python3.8/site-packages/ -type f -not -name "*.pyc" -printf "%P\n" | sort) <(find venv-after/lib/python3.8/site-packages/ -type f -not -name "*.pyc" -printf "%P\n" | sort)So those 4 extra files were included after this change.
Checklist: