Skip to content

Zipkin exporter report instrumentation info#1097

Merged
codeboten merged 4 commits intoopen-telemetry:masterfrom
dengliming:zipkin_report_instrumentation_info
Sep 14, 2020
Merged

Zipkin exporter report instrumentation info#1097
codeboten merged 4 commits intoopen-telemetry:masterfrom
dengliming:zipkin_report_instrumentation_info

Conversation

@dengliming
Copy link
Copy Markdown
Member

Fixes #1093

@dengliming dengliming requested a review from a team September 11, 2020 09:57
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the commit @dengliming! If you could update the changelog for the zipkin exporter, I can approve afterwards!

Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@codeboten codeboten merged commit 6588a70 into open-telemetry:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zipkin exporter must report instrumentation info

4 participants