Skip to content

Jaeger exporter report instrumentation info#1098

Merged
lzchen merged 5 commits intoopen-telemetry:masterfrom
dengliming:jaeger_report_instrumentation_info
Sep 15, 2020
Merged

Jaeger exporter report instrumentation info#1098
lzchen merged 5 commits intoopen-telemetry:masterfrom
dengliming:jaeger_report_instrumentation_info

Conversation

@dengliming
Copy link
Copy Markdown
Member

Fixes #1092

@dengliming dengliming requested a review from a team September 11, 2020 16:15
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Once this issue is addressed #1022, we should make sure to refactor this code to use generated strings for the keys in this PR.

@lzchen lzchen merged commit 071b1b3 into open-telemetry:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jaeger exporter must report instrumentation info

4 participants