dropping support for python 3.4#1099
Merged
codeboten merged 4 commits intoopen-telemetry:masterfrom Sep 14, 2020
Merged
Conversation
ocelotl
approved these changes
Sep 11, 2020
owais
approved these changes
Sep 12, 2020
ffe4
reviewed
Sep 13, 2020
Contributor
ffe4
left a comment
ffe4
left a comment
There was a problem hiding this comment.
We should probably remove the py34 stuff from the tox.ini as well if we do not want people running it.
Contributor
Author
Thanks for catching this, I missed it in the original pass. I'll also update the github workflow to drop 3.4. I'll fix changelogs as well. |
lzchen
approved these changes
Sep 14, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…1101 (open-telemetry#1099) This addresses open-telemetry#1101 open-telemetry#752, and open-telemetry#1013 - Fix context loss when used in some async cases
adamantike
added a commit
to adamantike/opentelemetry-python-contrib
that referenced
this pull request
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes open-telemetry#772.
6 tasks
adamantike
added a commit
to adamantike/opentelemetry-python-contrib
that referenced
this pull request
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes open-telemetry#772.
owais
pushed a commit
to open-telemetry/opentelemetry-python-contrib
that referenced
this pull request
Oct 25, 2021
Remove unwanted support for Python versions <3.6. This integration mistakenly lists Python 3.4 support, because it was merged in open-telemetry/opentelemetry-python#1039, after the merge of open-telemetry/opentelemetry-python#1099, so the latter didn't consider `falcon`. Python 3.4 is broken nevertheless, as this integration already includes f-strings and other `opentelemetry` dependencies, which require Python 3.6. Fixes #772.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed at the SIG meeting on Sep 10, it was agreed that dropping support for 3.4 would be better done before we reach GA. This has been previously discussed in this issue here: #25. Many instrumentations that we provide support for only support Python 3.5+ already. Python 3.4 was end of lifed over a year ago (Mar 2019)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: