Span.is_recording() now based off self._end_time and returns False if…#1289
Merged
lzchen merged 3 commits intoopen-telemetry:masterfrom Oct 29, 2020
Merged
Conversation
robwknox
requested review from
a team,
hectorhdzg and
owais
and removed request for
a team
codeboten
approved these changes
Oct 27, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for this change, I agree that this is a much simpler implementation 👍
lzchen
approved these changes
Oct 29, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Co-authored-by: Mayur Kale <mayurkale@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… span has ended
Description
Span.is_recording()is now based offself._end_timeand returnsFalseif a span has ended.Fixes (#1243)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox full run against pyenvs:
Checklist: