Align optional parameters for span related to exceptions, add exception.escaped for record_exception#1365
Merged
lzchen merged 12 commits intoopen-telemetry:masterfrom Nov 13, 2020
Merged
Conversation
aabmass
approved these changes
Nov 11, 2020
Comment on lines
+862
to
+863
| if span._record_exception: | ||
| span.record_exception(exc) |
Member
There was a problem hiding this comment.
Would it work if on line 854 if you did
with span:
yield spanto avoid repeating this code?
Contributor
Author
There was a problem hiding this comment.
This would work. The only reason why I left it in two different places is because record_exception wouldn't know if escaped is True or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start_as_current_span()andstart_span()should have identical constructors. For the parameters related to exception and status:record_exception()if exception raisedERRORif exception raisedAs well, from this comment,
adding
exception.escapedattribute when exception raised from span being used as a context manager.