Change temporality for Counter and UpDownCounter to CUMULATIVE#1384
Merged
codeboten merged 1 commit intoopen-telemetry:masterfrom Nov 18, 2020
Merged
Change temporality for Counter and UpDownCounter to CUMULATIVE#1384codeboten merged 1 commit intoopen-telemetry:masterfrom
codeboten merged 1 commit intoopen-telemetry:masterfrom
Conversation
ocelotl
requested review from
a team,
aabmass and
codeboten
and removed request for
a team
jmacd
approved these changes
Nov 16, 2020
codeboten
approved these changes
Nov 17, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Looks like there's some lint failures, otherwise this LGTM
Member
|
I left a comment on the issue, but I believe this should be derived from |
aabmass
approved these changes
Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1383
Description
Changes temporality for Counter and UpDownCounter to CUMULATIVE.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: