Use a delegate sampler for each possible case in ParentBased Sampler#1440
Merged
lzchen merged 9 commits intoopen-telemetry:masterfrom Dec 4, 2020
Merged
Use a delegate sampler for each possible case in ParentBased Sampler#1440lzchen merged 9 commits intoopen-telemetry:masterfrom
lzchen merged 9 commits intoopen-telemetry:masterfrom
Conversation
lzchen
requested review from
a team,
ocelotl and
owais
and removed request for
a team
aabmass
approved these changes
Dec 2, 2020
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
Looks like you're missing test coverage of passing in a different sampler for the new params
codeboten
approved these changes
Dec 4, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Just a nit about the tests, otherwise the PR looks.
| self.assertEqual(not_sampled_result.attributes, {}) | ||
| self.assertEqual(not_sampled_result.trace_state, trace_state) | ||
|
|
||
| with parent_sampling_context( |
Contributor
There was a problem hiding this comment.
nit: these tests could be refactored to make them easier, there's a lot of duplicate code here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1397