Skip to content

Add some repr()s to basic trace types.#1485

Merged
codeboten merged 5 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:trace-repr
Dec 18, 2020
Merged

Add some repr()s to basic trace types.#1485
codeboten merged 5 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:trace-repr

Conversation

@Oberon00
Copy link
Copy Markdown
Member

@Oberon00 Oberon00 commented Dec 16, 2020

Description

Improve __repr__ of DefaultSpan and SpanContext.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Only manually.

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

@Oberon00 Oberon00 requested review from a team, aabmass and owais and removed request for a team December 16, 2020 10:40
Copy link
Copy Markdown
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayyy nice, welcome back.

Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeboten
Copy link
Copy Markdown
Contributor

@Oberon00 if you can update the branch we can get this merged

@Oberon00
Copy link
Copy Markdown
Member Author

There seems to be a problem with pypy in CI:

Run actions/setup-python@v2
Error: IS_WINDOWS is not defined

@codeboten
Copy link
Copy Markdown
Contributor

@Oberon00 yes, the problem came from the underlying github action. this was fixed today if you want to update the branch again.

@codeboten codeboten merged commit 753ec6c into open-telemetry:master Dec 18, 2020
@Oberon00 Oberon00 deleted the trace-repr branch December 18, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants