Skip to content

Add support for OTEL_TRACE_SAMPLER and OTEL_TRACE_SAMPLER_ARG env variables#1496

Merged
lzchen merged 40 commits intoopen-telemetry:masterfrom
srikanthccv:trace-sampler-env
Jan 19, 2021
Merged

Add support for OTEL_TRACE_SAMPLER and OTEL_TRACE_SAMPLER_ARG env variables#1496
lzchen merged 40 commits intoopen-telemetry:masterfrom
srikanthccv:trace-sampler-env

Conversation

@srikanthccv
Copy link
Copy Markdown
Member

@srikanthccv srikanthccv commented Dec 19, 2020

Description

Fixes #1476

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • tox -e test-core-sdk

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@srikanthccv srikanthccv requested review from a team, codeboten and owais and removed request for a team December 19, 2020 09:26
@codeboten codeboten requested a review from lzchen January 7, 2021 16:15
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lzchen lzchen merged commit 9a1f594 into open-telemetry:master Jan 19, 2021
@srikanthccv srikanthccv deleted the trace-sampler-env branch September 24, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for OTEL_TRACE_SAMPLER + OTEL_TRACE_SAMPLER_ARG env variable

4 participants