Add max_tag_value_length support to Jaeger exporter#1633
Merged
codeboten merged 4 commits intoopen-telemetry:mainfrom Mar 1, 2021
Merged
Add max_tag_value_length support to Jaeger exporter#1633codeboten merged 4 commits intoopen-telemetry:mainfrom
max_tag_value_length support to Jaeger exporter#1633codeboten merged 4 commits intoopen-telemetry:mainfrom
Conversation
owais
force-pushed
the
jaeger-max-tag-value-length
branch
2 times, most recently
from
27619b5 to
463d4c8
Compare
owais
requested review from
a team,
codeboten and
hectorhdzg
and removed request for
a team
codeboten
reviewed
Feb 26, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
The changes to add max_attr_value_length look good, what happened w/ test_jaeger_exporter_protobuf.py?
lzchen
reviewed
Feb 26, 2021
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
| - Add `max_attr_value_length` support to Jaeger exporter | ||
| ([#1633])(https://github.com/open-telemetry/opentelemetry-python/pull/11633) |
Contributor
There was a problem hiding this comment.
Suggested change
| ([#1633])(https://github.com/open-telemetry/opentelemetry-python/pull/11633) | |
| ([#1633])(https://github.com/open-telemetry/opentelemetry-python/pull/1633) |
lzchen
approved these changes
Feb 26, 2021
Contributor
Author
|
Oh! My bad. I had added another test file and later deleted it but looks like I deleted the wrong file and in the process lost the new tests I wrote. I'll go back and write tests for it again now 🤦 |
owais
force-pushed
the
jaeger-max-tag-value-length
branch
from
463d4c8 to
2fcda90
Compare
owais
changed the title
max_attr_value_length support to Jaeger exportermax_tag_value_length support to Jaeger exporter
This commit adds ability to specifiy maximum length for string attributes to the Jaeger exporter. This is similar to how Zipkin exporter supports `max_tag_value_length`.
owais
force-pushed
the
jaeger-max-tag-value-length
branch
from
2fcda90 to
cea54d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds ability to specifiy maximum length for string
attributes to the Jaeger exporter. This is similar to how Zipkin
exporter supports
max_tag_value_length.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: