Conversation
owais
left a comment
There was a problem hiding this comment.
Contrib doesn't require any code changes but mentions the processor in docs in a couple of places so you might want to update that as well. https://github.com/open-telemetry/opentelemetry-python-contrib/search?q=BatchExportSpanProcessor
|
Actually it also uses SimpleExportSpanProcessor in a couple of tests. https://github.com/open-telemetry/opentelemetry-python-contrib/search?q=SimpleExportSpanProcessor Not sure why it didn't fail a contrib build. |
lzchen
left a comment
There was a problem hiding this comment.
I am also curious at how this did not break instrumentation tests.
I guess it didn't since the docker-tests failed. Will fix shortly |
Description
Renamed
BatchExportSpanProcessortoBatchSpanProcessorandSimpleExportSpanProcessortoSimpleSpanProcessorFixes #1634
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: