Cleanup OTLP exporter compression options, add tests#1671
Merged
lzchen merged 11 commits intoopen-telemetry:mainfrom Mar 12, 2021
Merged
Cleanup OTLP exporter compression options, add tests#1671lzchen merged 11 commits intoopen-telemetry:mainfrom
lzchen merged 11 commits intoopen-telemetry:mainfrom
Conversation
b22a69d to
034be2c
Compare
cb01c20 to
1847f38
Compare
da22731 to
8bf230a
Compare
srikanthccv
reviewed
Mar 5, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/trace_exporter/__init__.py
Show resolved
Hide resolved
ocelotl
suggested changes
Mar 5, 2021
8bf230a to
691fe0b
Compare
owais
reviewed
Mar 5, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
691fe0b to
afe803e
Compare
afe803e to
4e6e120
Compare
d8957bc to
e9e01f7
Compare
6 tasks
srikanthccv
approved these changes
Mar 10, 2021
lzchen
reviewed
Mar 10, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/trace_exporter/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Mar 10, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/exporter.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Mar 11, 2021
owais
approved these changes
Mar 11, 2021
codeboten
approved these changes
Mar 11, 2021
Contributor
|
@ocelotl |
ocelotl
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OTEL_EXPORTER_OTLP_SPAN_*->OTEL_EXPORTER_OTLP_TRACES_*per spec updateopentelemetry.sdk.environment_variablespackageFixed the changelog formatting 😄moved to Fixed changelog formatting issues #1679Relevant part of spec:
The gRPC python impl supports
Deflateso I have added it as well.Fixes #1327
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added lots of new test cases
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
opentelemetry-instrumentation/have changedThe method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: