Zipkin exporter to get service_name from span instead of global tracer_provider#1696
Merged
lzchen merged 9 commits intoopen-telemetry:mainfrom Mar 16, 2021
Merged
Zipkin exporter to get service_name from span instead of global tracer_provider#1696lzchen merged 9 commits intoopen-telemetry:mainfrom
lzchen merged 9 commits intoopen-telemetry:mainfrom
Conversation
lzchen
requested review from
a team,
codeboten and
srikanthccv
and removed request for
a team
srikanthccv
reviewed
Mar 16, 2021
Member
srikanthccv
left a comment
srikanthccv
left a comment
There was a problem hiding this comment.
Small question about max_tag_value_length otherwise LGTM.
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Outdated
Show resolved
Hide resolved
owais
reviewed
Mar 16, 2021
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Outdated
Show resolved
Hide resolved
codeboten
reviewed
Mar 16, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
I agree that we should revert the max_tag_value_length change, only another nit otherwise.
srikanthccv
approved these changes
Mar 16, 2021
codeboten
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1685