Change should_sample parameters to be spec compliant#1764
Merged
lzchen merged 9 commits intoopen-telemetry:mainfrom Apr 15, 2021
Merged
Change should_sample parameters to be spec compliant#1764lzchen merged 9 commits intoopen-telemetry:mainfrom
should_sample parameters to be spec compliant#1764lzchen merged 9 commits intoopen-telemetry:mainfrom
Conversation
codeboten
approved these changes
Apr 12, 2021
owais
approved these changes
Apr 13, 2021
srikanthccv
reviewed
Apr 13, 2021
Member
srikanthccv
left a comment
There was a problem hiding this comment.
Shouldn't we also update the should_sample to take trace_state from parent_context?
Contributor
Author
|
@lonewolf3739 |
Member
|
Does it make sense to move that to should_sample and add a note saying that is the recommended way and discourage people from using |
Contributor
Author
|
@lonewolf3739
This makes sense. I'll make these changes. |
Contributor
Author
|
@lonewolf3739 |
should_sample parameters to be spec compliant
ocelotl
approved these changes
Apr 14, 2021
Contributor
ocelotl
left a comment
There was a problem hiding this comment.
Approving, there is mostly a minor fix in documentation suggested.
srikanthccv
approved these changes
Apr 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1763
SpanKindtoshould_sampleshould_sampleusestrace_statefrom the passed inContext'sSpanContext'sTraceStateinstead of the explicitly passed inTraceState.