fix otlp grpc exporter bug when no scheme is passed in#1806
fix otlp grpc exporter bug when no scheme is passed in#1806codeboten merged 2 commits intoopen-telemetry:mainfrom
Conversation
ocelotl
left a comment
There was a problem hiding this comment.
Approving, but I think the interface is not intuitive. We have insecure which does not have a default value, if it is not set, then it is defined depending on the protocol or lack of it in the endpoint. So, we have 2 ways of setting insecure, one overrides the other. This is not documented (which is easy to fix), but I wonder if we would be better without this insecure argument at all.
|
@ocelotl yes I think the |
Maybe we should ignore the protocol at all, then? |
@ocelotl Using the protocol to determine secure/insecure is part of the specification. |
Description
When an endpoint without a protocol is passed in, urlparse sets the host as the scheme and leaves the net location empty. This changes catches that and skips setting the endpoint in that case.
Fixes #1801
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: