Added B3 multi-header propagator#1823
Merged
lzchen merged 5 commits intoopen-telemetry:mainfrom May 11, 2021
Merged
Conversation
owais
force-pushed
the
b3-multi-propagator
branch
6 times, most recently
from
a0a7769 to
be336dc
Compare
owais
requested review from
a team,
codeboten and
lzchen
and removed request for
a team
codeboten
approved these changes
May 6, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
| from opentelemetry.propagators.textmap import DefaultGetter | ||
|
|
||
| FORMAT = b3_format.B3Format() | ||
| B3_SINGLE = B3SingleFormat() |
Contributor
There was a problem hiding this comment.
nit: these variables are both only used once, not sure they're worth having.
owais
force-pushed
the
b3-multi-propagator
branch
2 times, most recently
from
3eccb3e to
9ee10fb
Compare
- Added B3MultiFormat and B3SingleFormat propagators. - B3Format is now deprecated and an alias to B3MultiFormat propagator. - Fixed `b3` entrypoint to point to `B3SingleFormat`. - Added `b3multi` entrypoint to point to `B3MultiFormat`.
codeboten
approved these changes
May 11, 2021
lzchen
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #1821
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: