Add support for OTEL_SERVICE_NAME env var.#1829
Merged
codeboten merged 3 commits intoopen-telemetry:mainfrom May 10, 2021
Merged
Add support for OTEL_SERVICE_NAME env var.#1829codeboten merged 3 commits intoopen-telemetry:mainfrom
codeboten merged 3 commits intoopen-telemetry:mainfrom
Conversation
owais
requested review from
a team,
codeboten and
srikanthccv
and removed request for
a team
owais
force-pushed
the
otel-service-name-env
branch
2 times, most recently
from
0c8e0b7 to
c409212
Compare
srikanthccv
approved these changes
May 9, 2021
lzchen
approved these changes
May 10, 2021
codeboten
reviewed
May 10, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Overall looks good, just one question regarding using the semconv.
| } | ||
| service_name = os.environ.get(OTEL_SERVICE_NAME) | ||
| if service_name: | ||
| env_resource_map["service.name"] = service_name |
Contributor
There was a problem hiding this comment.
Should this use the semconv package instead of the string for the key?
owais
force-pushed
the
otel-service-name-env
branch
from
a55cc11 to
c31bd4b
Compare
owais
force-pushed
the
otel-service-name-env
branch
from
c31bd4b to
7e8ea37
Compare
codeboten
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spec PR: open-telemetry/opentelemetry-specification#1677
Please review but don't merge until the spec PR is merged.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: