Add schema_url to Resource#1871
Merged
lzchen merged 40 commits intoopen-telemetry:mainfrom Jun 1, 2021
Merged
Conversation
Co-authored-by: Eddy Lin <elindy26@gmail.com>
Co-authored-by: Eddy Lin <elindy26@gmail.com>
…elemetry-python into add-schema_url-attribute
Improves readability from the last commit
This reverts commit 2801745.
|
|
8 tasks
dgetu
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
codeboten
suggested changes
May 26, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for taking this on, making the schema_url an optional argument would prevent the need to change all the calls to it in the tests. It will also prevent this from being a breaking change for users.
…dd-schema_url-attribute
lzchen
reviewed
May 26, 2021
lzchen
reviewed
May 26, 2021
lzchen
reviewed
May 26, 2021
lzchen
reviewed
May 26, 2021
Adds a test to verify the behavior of aggregating ResourceDetectors with different schema URLs. Verifies that merge error logs contain both conflicting URLs.
lzchen
approved these changes
May 27, 2021
codeboten
reviewed
May 27, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Nice I think this is getting pretty close, please take a look at my comments and update the branch!
codeboten
approved these changes
May 28, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1862
A change in the OTel specification requires a new
schema_urlfield in theResourceclass. This change implements the field, updates theResourcefactory method and merge method, updates the behavior ofOTELResourceDetectorwhen aggregatingResources, and modifies tests which used the old constructor signature.Type of change
How Has This Been Tested?
All
toxtests were ran on Python 3.9. Three tests were made or substantively modified, with a number of others modified for failing to conform to the new constructor signature.Does This PR Require a Contrib Repo Change?
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/Yes.
No.
Checklist: