Fix incorrect headers parsing via environment variables#2103
Merged
lzchen merged 10 commits intoopen-telemetry:mainfrom Sep 20, 2021
Merged
Fix incorrect headers parsing via environment variables#2103lzchen merged 10 commits intoopen-telemetry:mainfrom
lzchen merged 10 commits intoopen-telemetry:mainfrom
Conversation
codeboten
reviewed
Sep 7, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Since the format that we're parsing is in the spec, i would be ok with this being a public method available in the api. It's not a huge amount of code and could be useful to others.
ocelotl
suggested changes
Sep 7, 2021
owais
approved these changes
Sep 13, 2021
ocelotl
approved these changes
Sep 16, 2021
srikanthccv
added
the
Approve Public API check
This was referenced Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This introduces internal
parse_headersmethod following the spec for reading headers via environment variables. Fixes #1949