Fix validity calculation for trace/span ID#2145
Merged
lzchen merged 5 commits intoopen-telemetry:mainfrom Sep 29, 2021
Merged
Conversation
* fixes trace ID validation which was off by one and considered the max trace ID (0xffff...ffff) value as invalid. * adds check to also validate a span ID for its max value * adds checks that trace and span ID must not be negative
srikanthccv
reviewed
Sep 24, 2021
NathanielRN
reviewed
Sep 24, 2021
srikanthccv
approved these changes
Sep 24, 2021
NathanielRN
approved these changes
Sep 28, 2021
lzchen
approved these changes
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following issues for calculating the validity when creating a
SpanContext:2^128 -1) was actually considered invalid.2^64 - 1.Type of change
How Has This Been Tested?
adds additional unit tests
Does This PR Require a Contrib Repo Change?
Checklist: