Fix race in set_tracer_provider()#2182
Merged
owais merged 8 commits intoopen-telemetry:mainfrom Oct 12, 2021
Merged
Conversation
aabmass
changed the title
set_tracer_provider()
aabmass
force-pushed
the
set-tracer-provider-race
branch
from
ec0056b to
7edb787
Compare
aabmass
force-pushed
the
set-tracer-provider-race
branch
from
7edb787 to
30ba497
Compare
Member
Author
|
I believe all the Public API checks are false positives (tests or private module). |
owais
reviewed
Oct 6, 2021
owais
approved these changes
Oct 6, 2021
lzchen
approved these changes
Oct 6, 2021
ocelotl
reviewed
Oct 7, 2021
ocelotl
added
the
Approve Public API check
ocelotl
approved these changes
Oct 7, 2021
lzchen
reviewed
Oct 7, 2021
aabmass
commented
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an unlikely race condition where multiple threads can set the global tracer provider at once, bypassing the check that the global tracer provider can only be set once.
Fixes #2181
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
set_tracer_provider()in 100 threadsDoes This PR Require a Contrib Repo Change?
Checklist: