bugfix(auto-instrumentation): attach OTLPHandler to root logger#2450
Merged
lzchen merged 9 commits intoopen-telemetry:mainfrom Feb 10, 2022
Merged
bugfix(auto-instrumentation): attach OTLPHandler to root logger#2450lzchen merged 9 commits intoopen-telemetry:mainfrom
lzchen merged 9 commits intoopen-telemetry:mainfrom
Conversation
codeboten
reviewed
Feb 8, 2022
lzchen
reviewed
Feb 9, 2022
lzchen
approved these changes
Feb 9, 2022
codeboten
approved these changes
Feb 9, 2022
|
I don't think this patch is good for everyone. This forces the root logger to have the SDK's LogHandler instance no matter if auto instrumentation is applied for logging, more specifically even if it's explicitly disabled through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2448
Type of change
Please delete options that are not relevant.