Add a configurable max_export_batch_size to the gRPC metrics exporter

[overmeulen]

Description

Add a configurable max_export_batch_size to the gRPC metrics exporter.
This is to avoid reaching the 4MB gRPC limit when observables generate a lot metrics

Fixes #2710

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Added unit tests to test the split logic

Does This PR Require a Contrib Repo Change?

• Yes.
• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[overmeulen]

Thanks for all the comments, I will fix them.
One thing though, I think I'm not going deep enough when splitting the metrics_data.
I should apply the _max_export_batch_size to the number of data-points rather than the number of metrics.
WDYT ?

[srikanthccv]

Thanks for all the comments, I will fix them. One thing though, I think I'm not going deep enough when splitting the metrics_data. I should apply the _max_export_batch_size to the number of data-points rather than the number of metrics. WDYT ?

If I remember correctly, there will be one data point for each possible attribute set. So the number of metrics should be fine. In the issue, you noticed from your end what was the underlying issue? Was it number of points being high or total number of metrics exceeding the limit overall?

[overmeulen]

The number of points being high...

[srikanthccv]

Then you will probably have to divide the batch based on data points.

[ocelotl]

@overmeulen thanks, approving. Please don't force push your commits to your PR branch, it makes it hard to review new changes because the old commits don't show up anymore. Don't worry about how it will look in main when merged, before merging github will squash all commits into one.

[overmeulen]

@overmeulen thanks, approving. Please don't force push your commits to your PR branch, it makes it hard to review new changes because the old commits don't show up anymore. Don't worry about how it will look in main when merged, before merging github will squash all commits into one.

Noted for next time !

[aabmass]

Sorry for the late comments, feel free to merge maintainers. It can be addressed in a follow up.

[overmeulen]

I don't think the last failure is coming from my PR, I see the same failure on other PRs...

[srikanthccv]

Contrib SHA needs to be updated. It will be fixed in #2919