Skip to content

fix instrumenting_module_version typo#2830

Merged
srikanthccv merged 1 commit intoopen-telemetry:mainfrom
povilasv:fix-typo
Jul 18, 2022
Merged

fix instrumenting_module_version typo#2830
srikanthccv merged 1 commit intoopen-telemetry:mainfrom
povilasv:fix-typo

Conversation

@povilasv
Copy link
Copy Markdown
Contributor

@povilasv povilasv commented Jul 18, 2022

Description

Fix get_log_emitter instrumenting_module_version args typo

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [+] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@povilasv povilasv marked this pull request as ready for review July 18, 2022 08:19
@povilasv povilasv requested a review from a team July 18, 2022 08:19
@povilasv
Copy link
Copy Markdown
Contributor Author

povilasv commented Jul 18, 2022

Sorry forgot to add changelog, @oxeye-nikolay could you take a look again ? 🙇

@srikanthccv srikanthccv merged commit a3346ae into open-telemetry:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants