Add exponent and logarithm mappings#2960
Merged
ocelotl merged 24 commits intoopen-telemetry:mainfrom Nov 1, 2022
Merged
Conversation
ocelotl
force-pushed
the
issue_2957
branch
5 times, most recently
from
46458c4 to
18aa125
Compare
2 tasks
ocelotl
force-pushed
the
issue_2957
branch
5 times, most recently
from
81373db to
4429440
Compare
jmacd
approved these changes
Oct 12, 2022
...dk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/exponent_mapping.py
Outdated
Show resolved
Hide resolved
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/ieee_754.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
Oct 13, 2022
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/__init__.py
Show resolved
Hide resolved
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/__init__.py
Outdated
Show resolved
Hide resolved
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/__init__.py
Show resolved
Hide resolved
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/__init__.py
Outdated
Show resolved
Hide resolved
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/__init__.py
Show resolved
Hide resolved
...k/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/logarithm_mapping.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/tests/metrics/exponential_histogram/test_exponent_mapping.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/tests/metrics/exponential_histogram/test_exponent_mapping.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/tests/metrics/exponential_histogram/test_exponent_mapping.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/tests/metrics/exponential_histogram/test_logarithm_mapping.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
Oct 13, 2022
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/__init__.py
Show resolved
Hide resolved
aabmass
reviewed
Oct 13, 2022
...dk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/exponent_mapping.py
Show resolved
Hide resolved
...k/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/logarithm_mapping.py
Show resolved
Hide resolved
ocelotl
force-pushed
the
issue_2957
branch
10 times, most recently
from
70df507 to
f7b196a
Compare
…onent_mapping.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>
aabmass
approved these changes
Nov 1, 2022
...emetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/__init__.py
Show resolved
Hide resolved
This reverts commit 064bb2b.
srikanthccv
approved these changes
Nov 1, 2022
Member
srikanthccv
left a comment
srikanthccv
left a comment
There was a problem hiding this comment.
Minor comments, The tests helped better.
...dk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/exponent_mapping.py
Show resolved
Hide resolved
...k/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/mapping/logarithm_mapping.py
Show resolved
Hide resolved
jmacd
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2957
To make it easier to review this PR, here is a function that converts floating point values in IEEE 754 format along with some test cases.