Skip to content

Add http-metrics to semantic conventions#2976

Merged
ocelotl merged 2 commits intoopen-telemetry:mainfrom
lzchen:sem
Oct 13, 2022
Merged

Add http-metrics to semantic conventions#2976
ocelotl merged 2 commits intoopen-telemetry:mainfrom
lzchen:sem

Conversation

@lzchen
Copy link
Copy Markdown
Contributor

@lzchen lzchen commented Oct 12, 2022

No description provided.

@lzchen lzchen requested a review from a team October 12, 2022 19:27
@lzchen lzchen added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Oct 12, 2022
Copy link
Copy Markdown
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this code generated or you just manually added them?

@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Oct 12, 2022

@aabmass

Added manually. I know there's a gen script but it seems to be only for trace. I can create an issue to update it.

@ocelotl ocelotl merged commit 321f90f into open-telemetry:main Oct 13, 2022
@lzchen lzchen deleted the sem branch October 13, 2022 15:45
@lmolkova lmolkova mentioned this pull request Sep 28, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants