Select histogram aggregation with environment variables#3265
Merged
srikanthccv merged 9 commits intoopen-telemetry:mainfrom Apr 28, 2023
Merged
Select histogram aggregation with environment variables#3265srikanthccv merged 9 commits intoopen-telemetry:mainfrom
srikanthccv merged 9 commits intoopen-telemetry:mainfrom
Conversation
aabmass
approved these changes
Apr 19, 2023
lzchen
approved these changes
Apr 19, 2023
Member
|
I wouldn't put any OTLP exporter specific implementation in metrics SDK. The default aggregation from SDK should return the default irrespective of this env, and it should only be considered when the used exporter is OTLP. Each metric exporter has the option to configure the preferred aggregation and temporality. And I believe this logic should go in OTLP metrics exporters, similar to |
Contributor
Author
|
@srikanthccv moved this feature to the exporter, PTAL. |
srikanthccv
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3264