Add stack trace on StatusCode.UNKNOWN export error#3536
Merged
lzchen merged 3 commits intoopen-telemetry:mainfrom Nov 22, 2023
Merged
Add stack trace on StatusCode.UNKNOWN export error#3536lzchen merged 3 commits intoopen-telemetry:mainfrom
StatusCode.UNKNOWN export error#3536lzchen merged 3 commits intoopen-telemetry:mainfrom
Conversation
lzchen
approved these changes
Nov 20, 2023
Contributor
lzchen
left a comment
lzchen
left a comment
There was a problem hiding this comment.
Please add a changelog entry
jakewins
added a commit
to jakewins/opentelemetry-python
that referenced
this pull request
Nov 22, 2023
A deployment I ran over the weekend is logging the following message hundreds of times per minute: > "Failed to export metrics to otlp.eu01.nr-data.net, error code: StatusCode.UNKNOWN" For this status code - 'Unknown' - it would be nice to have the full error logged, as the message above is very hard to debug.
jakewins
force-pushed
the
jake/exc-info-unknown-export
branch
from
8d8b107 to
cadc5ae
Compare
Contributor
Author
|
@lzchen done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A deployment I ran over the weekend is logging the following message hundreds of times per minute:
For this status code - 'Unknown' - it would be nice to have the full error logged, as the message above is very hard to debug.
Type of change
How Has This Been Tested?
I've added a unit test,
test_unknown_logs, but haven't been able to run it, because I'm struggling a bit with how to set up this project for development.If this patchset seems useful to include, I'm happy to invest some time to get the test sorted properly. I asked in the slack channel for some help with how people normally set up the project for development.
Does This PR Require a Contrib Repo Change?
Checklist: