Use Attribute rather than boundattribute in logrecord repr#3567
Merged
ocelotl merged 2 commits intoopen-telemetry:mainfrom Feb 16, 2024
pegasas:issues3547
Merged
Use Attribute rather than boundattribute in logrecord repr#3567ocelotl merged 2 commits intoopen-telemetry:mainfrom pegasas:issues3547
ocelotl merged 2 commits intoopen-telemetry:mainfrom
pegasas:issues3547
Conversation
Member
|
This is not the correct fix. We should continue to use bounded attributes but the repr and string methods should be fixed. |
Contributor
Author
Thanks for guidance. |
6 tasks
Contributor
|
@srikanthccv PTAL, I think @pegasas has added a fix for your comment. |
fix lint
Contributor
Author
Thanks for calling out. |
Contributor
|
@pegasas @srikanthccv @ocelotl I think changelog in this PR is misleading |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3547
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: