Add ProxyLoggerProvider, ProxyLogger and associated tests#3575
Merged
ocelotl merged 8 commits intoopen-telemetry:mainfrom Feb 9, 2024
Merged
Add ProxyLoggerProvider, ProxyLogger and associated tests#3575ocelotl merged 8 commits intoopen-telemetry:mainfrom
ocelotl merged 8 commits intoopen-telemetry:mainfrom
Conversation
srikanthccv
reviewed
Dec 31, 2023
Member
srikanthccv
left a comment
There was a problem hiding this comment.
Mostly LGTM, some comments
Contributor
Author
|
@srikanthccv Do you need anything more from me here? I'm really keen to do anything we can to progress logs to stable as I'm looking to get them into production where I work this year. |
srikanthccv
reviewed
Feb 3, 2024
Member
srikanthccv
left a comment
There was a problem hiding this comment.
Minor comment about changelog entry, otherwise looks good to me.
srikanthccv
approved these changes
Feb 3, 2024
Member
srikanthccv
left a comment
There was a problem hiding this comment.
Thanks, Please take a look at #3361 if you are interested in helping make logs SDK stable.
ocelotl
approved these changes
Feb 8, 2024
Contributor
Author
|
@ocelotl Sorry I misread what had happened here and deleted my branch, which closed the PR. Reopening so this can be merged properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves issue 3060 by adding ProxyLoggerProvider, ProxyLogger and associated tests.
Fixes #3060
Type of change
How Has This Been Tested?
Test cases added and passing with
tox -e opentelemetry-apiDoes This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: