Handle HTTP 2XX responses as successful in OTLP exporters#3623
Merged
ocelotl merged 6 commits intoopen-telemetry:mainfrom Jan 26, 2024
gshiva:handle-2xx-as-succcess
Merged
Handle HTTP 2XX responses as successful in OTLP exporters#3623ocelotl merged 6 commits intoopen-telemetry:mainfrom gshiva:handle-2xx-as-succcess
ocelotl merged 6 commits intoopen-telemetry:mainfrom
gshiva:handle-2xx-as-succcess
Conversation
Contributor
|
Just for reference. |
ocelotl
approved these changes
Jan 10, 2024
ocelotl
suggested changes
Jan 11, 2024
Contributor
ocelotl
left a comment
ocelotl
left a comment
There was a problem hiding this comment.
Marking as request changes to avoid accidental merging, there is still an important question to answer here.
...xporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/__init__.py
Show resolved
Hide resolved
ocelotl
approved these changes
Jan 25, 2024
auto-merge was automatically disabled
January 25, 2024 23:42
Pull Request is not mergeable
This was referenced Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change modifies the OTLP exporters to treat HTTP 204 responses as successful. Previously, these were logged as errors and returned an error code, even though a 204 status code indicates a successful request. This change prevents unnecessary pollution of the logs.
Fixes #3621
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested this change locally by using the modified code and verified that it works as expected. Specifically, I sent logs to the Grafana OTLP endpoint and confirmed that a 204 status code no longer results in an error message or error code.
[x] Test A: Sent logs to Grafana OTLP endpoint and confirmed correct behavior
Does This PR Require a Contrib Repo Change?
Checklist: