Skip to content

Log a warning when an attribute is discarded due to limits#3946

Merged
lzchen merged 8 commits intoopen-telemetry:mainfrom
emdneto:issue3935
Jun 13, 2024
Merged

Log a warning when an attribute is discarded due to limits#3946
lzchen merged 8 commits intoopen-telemetry:mainfrom
emdneto:issue3935

Conversation

@emdneto
Copy link
Copy Markdown
Member

@emdneto emdneto commented May 31, 2024 •
edited by xrmx
Loading

Description

Fixes #3935

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py311-opentelemetry-sdk

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@emdneto emdneto marked this pull request as ready for review June 1, 2024 15:20
@emdneto emdneto requested a review from a team June 1, 2024 15:20
@emdneto
Copy link
Copy Markdown
Member Author

emdneto commented Jun 1, 2024 •
edited
Loading

docs ci is failing because of this aio-libs/aiohttp#8434
Solved

@emdneto emdneto marked this pull request as draft June 1, 2024 15:27
xrmx
xrmx reviewed Jun 1, 2024
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@emdneto emdneto marked this pull request as ready for review June 2, 2024 02:17
pmcollins
pmcollins reviewed Jun 3, 2024
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@emdneto emdneto requested review from pmcollins and xrmx June 3, 2024 16:47
@lzchen lzchen merged commit ea15f72 into open-telemetry:main Jun 13, 2024
@tammy-baylis-swi tammy-baylis-swi mentioned this pull request Jun 11, 2025
Merged
12 tasks
@aabmass aabmass mentioned this pull request Oct 14, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

@pmcollins pmcollins Awaiting requested review from pmcollins

@xrmx xrmx Awaiting requested review from xrmx

Assignees

No one assigned

Labels

None yet

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

logs: Log a warning when an attribute is discarded due to limits

4 participants

@emdneto @xrmx @pmcollins @lzchen
⚡