Implement Client Key and Certificate File Support for All OTLP Exporters#4116
Conversation
…ertificate-for-otlp-exporters
…ttps://github.com/chittalpatel/opentelemetry-python into 2991-client-key-and-certificate-for-otlp-exporters
emdneto
added
the
Approve Public API check
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
Thanks for taking this on. I believe you've brought these changes in from another PR, but I've made some comments below.
- Moved `client_key_file` and `client_certificate_file` to local variables as suggested. - Added a comment explaining the retention of these as instance variables for testing purposes. - Addressed all review comments to improve code readability and maintainability.
|
@pmcollins Thank you for your comments, resolved accordingly :) |
- Moved `client_key_file` and `client_certificate_file` to local variables as suggested. - Added a comment explaining the retention of these as instance variables for testing purposes. - Addressed all review comments to improve code readability and maintainability.
sandy2008
force-pushed
the
2991-client-key-and-certificate-for-otlp-exporters
branch
from
92ebea0 to
d254a53
Compare
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
Thanks for considering my feedback. Can you push your PR updates -- I'm not seeing them here.
Hi @pmcollins :) Thank you for your reply! |
Oh sorry, it's fine -- I think it was a problem on my end. |
…ttps://github.com/sandy2008/opentelemetry-python into 2991-client-key-and-certificate-for-otlp-exporters
|
@pmcollins Hi, please help review again :) |
…ttps://github.com/sandy2008/opentelemetry-python into 2991-client-key-and-certificate-for-otlp-exporters
|
@pmcollins Hi! I think all the above comments & changes are resolved & made :) |
|
@pmcollins Hi, all the issues have been resolved :) |
…ttps://github.com/sandy2008/opentelemetry-python into 2991-client-key-and-certificate-for-otlp-exporters
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the changes.
@pmcollins Thanks! What is the step before we can get it merged btw :) |
No problem at all. Leighton and/or Diego will take it from here. |
Thanks! @lzchen , @ocelotl Please help merge it if you have time :)! |
9 participants
Description
This PR extends the support for client key files and client certificate files to all OTLP exporters, building on the initial work from #3590, which is no longer maintained.
Type of change
How Has This Been Tested?
Tests have been updated and validated using the following commands:
tox -e opentelemetry-exporter-otlp-proto-grpctox -e opentelemetry-exporter-otlp-proto-httpDoes This PR Require a Contrib Repo Change?
Checklist:
License Information
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE LICENSE V.2.0. YOU MAY OBTAIN A COPY OF THE LICENSE AT https://github.com/open-telemetry/opentelemetry-python/blob/master/LICENSE.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.