Fix type checking for built in metric exporters#4820
Merged
xrmx merged 1 commit intoopen-telemetry:mainfrom Nov 27, 2025
Merged
Fix type checking for built in metric exporters#4820xrmx merged 1 commit intoopen-telemetry:mainfrom
xrmx merged 1 commit intoopen-telemetry:mainfrom
Conversation
7 tasks
xrmx
reviewed
Nov 26, 2025
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
Can you also remove opentelemetry-sdk/src/opentelemetry/sdk/error_handler and opentelemetry-sdk/src/opentelemetry/sdk/util while you are at it? No work should be needed. The commit suggest you only touched metrics but you fixed and then removed from exclusion a trace file.
aabmass
force-pushed
the
push-vzsomwomlkxl
branch
from
3afa2ae to
5297e4d
Compare
Member
Author
|
Oops ya I didn't even mean to remove that line. Removed those from exclude and also narrowed it down to just the |
emdneto
approved these changes
Nov 26, 2025
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
Glad to see the exclude list is getting smaller 🚀
xrmx
approved these changes
Nov 27, 2025
JWinermaSplunk
pushed a commit
to JWinermaSplunk/opentelemetry-python
that referenced
this pull request
Feb 17, 2026
JWinermaSplunk
pushed a commit
to JWinermaSplunk/opentelemetry-python
that referenced
this pull request
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes errors about unknown type for users using
InMemoryMetricExporterandConsoleMetricExporter. Also removed a bunch of paths from pyright excludes to expand type checking coverageType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: