Skip to content

fix(http-metric-exporter): use consistent protobuf for export request#5015

Merged
xrmx merged 4 commits intoopen-telemetry:mainfrom
anuraaga:http-metric-exporter-types
Apr 1, 2026
Merged

fix(http-metric-exporter): use consistent protobuf for export request#5015
xrmx merged 4 commits intoopen-telemetry:mainfrom
anuraaga:http-metric-exporter-types

Conversation

@anuraaga
Copy link
Copy Markdown
Contributor

Description

Fixes #5014

Use ExportMetricServiceRequest consistently for exporting metrics as it is the collector's export endpoint type (MetricsData is for saving but happens to be compatible so it seems to be working)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@anuraaga anuraaga requested a review from a team as a code owner March 27, 2026 01:11
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for some cleanup! I checked this out and it also works with my use case.

@xrmx xrmx moved this to Ready for review in Python PR digest Mar 30, 2026
…try/exporter/otlp/proto/http/metric_exporter/__init__.py
@xrmx xrmx enabled auto-merge (squash) April 1, 2026 09:01
@xrmx xrmx merged commit db134a3 into open-telemetry:main Apr 1, 2026
508 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in Python PR digest Apr 1, 2026
Vitexus pushed a commit to Vitexus/opentelemetry-python that referenced this pull request Apr 30, 2026
…open-telemetry#5015)

* fix(http-metric-exporter): use consistent protobuf for export request

* changelog

* Update exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/metric_exporter/__init__.py

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

HTTP metric exporter uses different protos when batching or not

3 participants