ext: Rename http_requests to requests#619
Merged
toumorokoshi merged 3 commits intoopen-telemetry:masterfrom May 3, 2020
mauriciovasquezbernal:mauricio/rename-http-requests
Merged
ext: Rename http_requests to requests#619toumorokoshi merged 3 commits intoopen-telemetry:masterfrom mauriciovasquezbernal:mauricio/rename-http-requests
toumorokoshi merged 3 commits intoopen-telemetry:masterfrom
mauriciovasquezbernal:mauricio/rename-http-requests
Conversation
mauriciovasquezbernal
added
ext
instrumentation
All the integrations use opentelemetry.ext.<instrumented library name here>
hectorhdzg
approved these changes
May 1, 2020
Member
hectorhdzg
left a comment
hectorhdzg
left a comment
There was a problem hiding this comment.
LGTM, about original issue not sure how that one was triggered, I never had issues using pymongo for the ext name
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: update CHANGELOG.md * chore: update README, add npm version badge * fix: npm-url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requests integration is named
http-requestsbecause at the time it was created there were some problems with pylint. This commit and the conversation on this comment have more information about that.I think the problem is not present anymore (other integrations are using opentelemetry.ext.integration without problems), I renamed it and the tests are passing without issues.