infra: reduce build time by running longest job early#626
Merged
c24t merged 2 commits intoopen-telemetry:masterfrom Apr 29, 2020
Merged
infra: reduce build time by running longest job early#626c24t merged 2 commits intoopen-telemetry:masterfrom
c24t merged 2 commits intoopen-telemetry:masterfrom
Conversation
codeboten
force-pushed
the
reduce-build-times
branch
from
1f01472 to
0523233
Compare
mauriciovasquezbernal
approved these changes
Apr 28, 2020
Member
mauriciovasquezbernal
left a comment
mauriciovasquezbernal
left a comment
There was a problem hiding this comment.
LGTM!
To reviewers, it's not only about reducing the build time but also about fixing it, as done in the second commit of this PR.
lzchen
approved these changes
Apr 29, 2020
c24t
approved these changes
Apr 29, 2020
Member
c24t
left a comment
c24t
left a comment
There was a problem hiding this comment.
Thanks @codeboten.
Do you know where the 5 job max is configured? It doesn't look like it's at the repository level, https://travis-ci.org/github/open-telemetry/opentelemetry-python/settings shows:
Contributor
Author
|
@c24t looks like it's part of the free plan according to https://travis-ci.com/plans
|
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…-telemetry#653) * fix: do not load plugin when they patch a different module than defined in config open-telemetry#626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently builds take roughly 15 minutes, as the longest job (pypy3) isn't kicked off until one of the other jobs is finished running (max 5 concurrent jobs). Prioritizing the longer jobs first should reduce the build time by about 5 minutes.