Add reset for configuration testing#636
Merged
toumorokoshi merged 5 commits intoopen-telemetry:masterfrom May 5, 2020
Merged
Conversation
ocelotl
added
api
mauriciovasquezbernal
approved these changes
May 4, 2020
Member
mauriciovasquezbernal
left a comment
mauriciovasquezbernal
left a comment
There was a problem hiding this comment.
LGTM, just a nit.
Should this include a test for _reset as well?
Comment on lines
+131
to
+132
| It is not intended to be used by production code but by testing code | ||
| only. |
Member
There was a problem hiding this comment.
Suggested change
| It is not intended to be used by production code but by testing code | |
| only. | |
| It is intended to be used by testing code only. |
toumorokoshi
suggested changes
May 5, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Switching mine to request changes, as a test is really important.
lzchen
approved these changes
May 5, 2020
Contributor
Author
|
Added the test you requested, @toumorokoshi 👍 |
toumorokoshi
reviewed
May 5, 2020
Member
|
@ocelotl one last comment / discussion, thanks! |
toumorokoshi
approved these changes
May 5, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…-telemetry#636 (open-telemetry#654) * feat: warn user when a instrumented package was already required open-telemetry#636 * chore: address PR comments * chore: extract package name from require.cache * chore: use find instead of some * chore: use require.resolve to find already required modules * chore: try/catch require.resolve Co-authored-by: Mayur Kale <mayurkale@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #634