Handle boolean, integer and float values in Configuration#662
Merged
toumorokoshi merged 3 commits intoopen-telemetry:masterfrom May 20, 2020
Merged
Handle boolean, integer and float values in Configuration#662toumorokoshi merged 3 commits intoopen-telemetry:masterfrom
toumorokoshi merged 3 commits intoopen-telemetry:masterfrom
Conversation
ocelotl
added
enhancement
ocelotl
changed the title
toumorokoshi
approved these changes
May 19, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
nice! I do have a thought on accepting more than just capital T/F for bool, but that could be relaxed later on. Thanks!
| OpenTelemetry API provided providers are the default ones used if no | ||
| configuration is found in the environment variables). | ||
|
|
||
| Configuration values that are exactly ``"True"`` or ``"False"`` will be |
Member
There was a problem hiding this comment.
typically lowercase "true" or "false" work here as well. Thoughts on accepting those?
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #647