infra: accelerate builds#693
Merged
codeboten merged 15 commits intoopen-telemetry:masterfrom May 21, 2020
Merged
Conversation
this should reduce the build times for py38
Member
|
Cool! I'd probably say the overhead of running pip multiple times is not a big issue (Python vm startup ~100ms, maybe an additional 100ms to load the core bytecode). But the lint re-order makes a lot of sense! Nice stuff. |
toumorokoshi
approved these changes
May 19, 2020
Member
toumorokoshi
left a comment
There was a problem hiding this comment.
approving assuming build will pass. Thanks!
lzchen
reviewed
May 19, 2020
| ; Install without -e to test the actual installation | ||
| python -m pip install -U pip setuptools wheel | ||
|
|
||
| py3{4,5,6}: python -m pip install -U pip setuptools wheel |
Contributor
There was a problem hiding this comment.
Any reason why we still need this line if it is run in travis.yml?
Contributor
Author
There was a problem hiding this comment.
Unfortunately, upgrading pip in travis before bringing up virtualenvs via tox was part of a failed experiment. I've reverted the change in the travis file, and kept the pip install -U command for the versions of python that needed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some build time improvements: