Rename otcollector to opencensus#695
Conversation
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This is looking pretty good, thanks for the PR! I would like to see an integration test against an OpenCensus collector before approving this.
ext/opentelemetry-ext-opencensus/src/opentelemetry/ext/opencensus/__init__.py
Outdated
Show resolved
Hide resolved
|
|
||
| from opentelemetry import trace | ||
| from opentelemetry.ext.otcollector.trace_exporter import CollectorSpanExporter | ||
| from opentelemetry.ext.opencensus.trace_exporter import CollectorSpanExporter |
There was a problem hiding this comment.
Should the name of the exporters be updated to reflect this is specifically for the OpenCensus Collector as opposed to the OpenTelemetry collector? I don't know if it will create confusion to have multiple CollectorSpanExporter or if the package naming is differentiating enough.
There was a problem hiding this comment.
I fixed some naming in the last commit, please let me know if it is right now 👍
ocelotl
force-pushed
the
issue_541
branch
2 times, most recently
from
611521a to
02412de
Compare
hectorhdzg
left a comment
hectorhdzg
left a comment
There was a problem hiding this comment.
LGTM, is great this one come with docker tests as well
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This looks great, thanks for adding the integration tests. Just one question I'm waiting for a response on, otherwise I'll approve and merge.
...ext-opencensusexporter/src/opentelemetry/ext/opencensusexporter/metrics_exporter/__init__.py
Show resolved
Hide resolved
…sus/__init__.py Co-authored-by: alrex <alrex.boten@gmail.com>
This is done to keep the test code while the OpenCensus issue reported (census-instrumentation/opencensus-service#641) gets fixed.
5 participants
Fixes #541