Skip to content

infra: adding step to publish action #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeboten merged 5 commits into from
May 26, 2020
Merged

infra: adding step to publish action #733

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb69550
infra: adding step to publish action
May 25, 2020
6372e1f
install twine separately
May 26, 2020
1bc8167
adding comment
May 26, 2020
9d472fc
Merge branch 'master' into infra/check-against-testpypi
May 26, 2020
950ce75
Merge branch 'master' into infra/check-against-testpypi
May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,16 @@ jobs:
python-version: '3.7'
- name: Build wheels
run: ./scripts/build.sh
- name: Publish to TestPyPI
env:
TWINE_USERNAME: ${{ secrets.test_pypi_username }}
TWINE_PASSWORD: ${{ secrets.test_pypi_password }}
run: |
pip install twine
Copy link
Copy Markdown
Contributor

@owais owais May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should installing deps/tools be an independent step before other steps that depend on it?

Copy link
Copy Markdown
Contributor Author

@codeboten codeboten May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done.

twine upload --repository testpypi --skip-existing --verbose dist/*
- name: Publish to PyPI
env:
TWINE_USERNAME: '__token__'
TWINE_PASSWORD: ${{ secrets.pypi_password }}
run: |
pip install twine
twine upload --skip-existing --verbose dist/*
⚡